Mojom: Add 'default' keyword for initializing structs to non-null value.

Mojom: Add 'default' keyword for initializing structs to non-null value.

Also simplify the code generation for initializing default values.

BUG=320082
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275366

[viettrungluu, 2014-06-05 03:32:03]

https://codereview.chromium.org/317073005/diff/1/mojo/public/cpp/bindings/tes...
File mojo/public/cpp/bindings/tests/sample_service_unittest.cc (right):

https://codereview.chromium.org/317073005/diff/1/mojo/public/cpp/bindings/tes...
mojo/public/cpp/bindings/tests/sample_service_unittest.cc:364:
EXPECT_FALSE(defaults->a22.is_null());
Probably this should be "ASSERT_FALSE". <shrug>

https://codereview.chromium.org/317073005/diff/1/mojo/public/tools/bindings/p...
File mojo/public/tools/bindings/pylib/mojom/parse/lexer.py (right):

https://codereview.chromium.org/317073005/diff/1/mojo/public/tools/bindings/p...
mojo/public/tools/bindings/pylib/mojom/parse/lexer.py:69: 'DEFAULT',
Could you add this to the lexer unit test?

[viettrungluu, 2014-06-05 03:32:30]

(Also, since I'm too lazy to check right now, is there a java test that needs to
be updated?)

[qsr, 2014-06-05 08:04:35]

On 2014/06/05 03:32:30, viettrungluu wrote:
> (Also, since I'm too lazy to check right now, is there a java test that needs
to
> be updated?)

 Struct are in the process of being reviewed. So no changed needed yet.

[Matt Perry, 2014-06-05 19:36:56]

https://codereview.chromium.org/317073005/diff/1/mojo/public/cpp/bindings/tes...
File mojo/public/cpp/bindings/tests/sample_service_unittest.cc (right):

https://codereview.chromium.org/317073005/diff/1/mojo/public/cpp/bindings/tes...
mojo/public/cpp/bindings/tests/sample_service_unittest.cc:364:
EXPECT_FALSE(defaults->a22.is_null());
On 2014/06/05 03:32:03, viettrungluu wrote:
> Probably this should be "ASSERT_FALSE". <shrug>

Done.

https://codereview.chromium.org/317073005/diff/1/mojo/public/tools/bindings/p...
File mojo/public/tools/bindings/pylib/mojom/parse/lexer.py (right):

https://codereview.chromium.org/317073005/diff/1/mojo/public/tools/bindings/p...
mojo/public/tools/bindings/pylib/mojom/parse/lexer.py:69: 'DEFAULT',
On 2014/06/05 03:32:03, viettrungluu wrote:
> Could you add this to the lexer unit test?

Done. I also fixed some parser_unittest breakages from my last CL, since I had
forgotten to run it.

[Matt Perry, 2014-06-05 21:17:34]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:18:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/317073005/40001

[commit-bot: I haz the power, 2014-06-05 21:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:18:54]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[viettrungluu, 2014-06-05 21:27:55]

lgtm

[Matt Perry, 2014-06-05 21:34:28]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:36:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/317073005/40001

[commit-bot: I haz the power, 2014-06-06 02:25:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-06 10:07:56]

Change committed as 275366