mojo/public/interfaces/bindings/tests/sample_service.mojom - Issue 317073005: Mojom: Add 'default' keyword for initializing structs to non-null value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/sample_service.mojom

Issue 317073005: Mojom: Add 'default' keyword for initializing structs to non-null value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/sample_service_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/sample_service.mojom

diff --git a/mojo/public/interfaces/bindings/tests/sample_service.mojom b/mojo/public/interfaces/bindings/tests/sample_service.mojom

index 38a40e40db767c1f9aa1784f8bc69dfadb4f80a0..9a4694b6f8b92639b4bf5b5c8d4c68a5399af210 100644

--- a/mojo/public/interfaces/bindings/tests/sample_service.mojom

+++ b/mojo/public/interfaces/bindings/tests/sample_service.mojom

@@ -50,8 +50,8 @@ struct DefaultsTest {

int32 a4@4 = 123456;

// TODO(vtl): crbug.com/375522

uint32 a5@5 /* = 3456789012 */;

- // TODO(vtl): crbug.com/375522

int64 a6@6 = 111111111111;

+ // TODO(vtl): crbug.com/375522

uint64 a7@7 /* = 9999999999999999999 */;

int32 a8@8 = 0x12345;

int32 a9@9 = -0x12345;

@@ -71,7 +71,7 @@ struct DefaultsTest {

Bar.Type a20@20 = Bar.TYPE_BOTH;

imported.Point a21@21;

- imported.Thing a22@22;

+ imported.Thing a22@22 = default;

};

struct StructWithHoleV1 {