mojo/public/cpp/bindings/tests/sample_service_unittest.cc - Issue 317073005: Mojom: Add 'default' keyword for initializing structs to non-null value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

Issue 317073005: Mojom: Add 'default' keyword for initializing structs to non-null value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/public/interfaces/bindings/tests/sample_service.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc

index a079d299a715d48859adfe7c3f0389aa836ce618..23b0dbdf06f4aacc572c13dee81adcd0298cada1 100644

--- a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc

@@ -359,9 +359,11 @@ TEST(BindingsSampleTest, DefaultValues) {

EXPECT_DOUBLE_EQ(1.23E-20, defaults->a17);

EXPECT_TRUE(defaults->a18.is_null());

EXPECT_TRUE(defaults->a19.is_null());

- // TODO(mpcomplete): Test defaults.Point and defaults.Thing once we can

- // initialize them to "default".

EXPECT_EQ(Bar::TYPE_BOTH, defaults->a20);

+ EXPECT_TRUE(defaults->a21.is_null());

+ ASSERT_FALSE(defaults->a22.is_null());

+ EXPECT_EQ(imported::SHAPE_RECTANGLE, defaults->a22->shape);

+ EXPECT_EQ(imported::COLOR_BLACK, defaults->a22->color);

}

} // namespace

« no previous file with comments | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/public/interfaces/bindings/tests/sample_service.mojom » ('j') | no next file with comments »