Issue 316903003: Mark test results with unknown status as unreliable

Issue 316903003: Mark test results with unknown status as unreliable (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mark test results with unknown status as unreliable This takes into account test retries, and only looks at the final result. BUG=381733 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276403

Patch Set 3 : const #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -25 lines)			Patch
M	base/test/launcher/test_launcher.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	base/test/launcher/test_results_tracker.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	base/test/launcher/test_results_tracker.cc	View	1 2	3 chunks	+29 lines, -22 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/316903003/diff/1/base/test/launcher/test_launcher.cc File base/test/launcher/test_launcher.cc (right): https://codereview.chromium.org/316903003/diff/1/base/test/launcher/test_launcher.cc#newcode871 base/test/launcher/test_launcher.cc:871: if (!tests_by_status[TestResult::TEST_UNKNOWN].empty()) { nit: no {} https://codereview.chromium.org/316903003/diff/1/base/test/launcher/test_results_tracker.cc File ...

6 years, 6 months ago (2014-06-09 16:04:27 UTC) #2

Paweł Hajdan Jr.

https://codereview.chromium.org/316903003/diff/1/base/test/launcher/test_launcher.cc File base/test/launcher/test_launcher.cc (right): https://codereview.chromium.org/316903003/diff/1/base/test/launcher/test_launcher.cc#newcode871 base/test/launcher/test_launcher.cc:871: if (!tests_by_status[TestResult::TEST_UNKNOWN].empty()) { On 2014/06/09 16:04:27, sky wrote: > ...

6 years, 6 months ago (2014-06-10 15:55:01 UTC) #3

sky

SLGTM https://codereview.chromium.org/316903003/diff/20001/base/test/launcher/test_results_tracker.cc File base/test/launcher/test_results_tracker.cc (right): https://codereview.chromium.org/316903003/diff/20001/base/test/launcher/test_results_tracker.cc#newcode345 base/test/launcher/test_results_tracker.cc:345: TestResult result = j->second.test_results.back(); const TestResult& result =...

6 years, 6 months ago (2014-06-10 16:28:22 UTC) #4

Paweł Hajdan Jr.

https://codereview.chromium.org/316903003/diff/20001/base/test/launcher/test_results_tracker.cc File base/test/launcher/test_results_tracker.cc (right): https://codereview.chromium.org/316903003/diff/20001/base/test/launcher/test_results_tracker.cc#newcode345 base/test/launcher/test_results_tracker.cc:345: TestResult result = j->second.test_results.back(); On 2014/06/10 16:28:22, sky wrote: ...

6 years, 6 months ago (2014-06-11 10:27:12 UTC) #5

Paweł Hajdan Jr.

6 years, 6 months ago (2014-06-11 15:11:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r276403 (presubmit successful).

Expand Messages | Collapse Messages