Mark test results with unknown status as unreliable

base/test/launcher/test_results_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/launcher/test_results_tracker.h"
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
@@ skipping 164 matching lines @@
 }
 
 void TestResultsTracker::AddTestResult(const TestResult& result) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   per_iteration_data_[iteration_].results[
       result.full_name].test_results.push_back(result);
 }
 
 void TestResultsTracker::PrintSummaryOfCurrentIteration() const {
-  std::map<TestResult::Status, std::set<std::string> > tests_by_status;
-
-  for (PerIterationData::ResultsMap::const_iterator j =
-           per_iteration_data_[iteration_].results.begin();
-       j != per_iteration_data_[iteration_].results.end();
-       ++j) {
-    // Use the last test result as the final one.
-    TestResult result = j->second.test_results.back();
-    tests_by_status[result.status].insert(result.full_name);
-  }
+  TestStatusMap tests_by_status(GetTestStatusMapForCurrentIteration());
 
   PrintTests(tests_by_status[TestResult::TEST_FAILURE].begin(),
              tests_by_status[TestResult::TEST_FAILURE].end(),
              "failed");
   PrintTests(tests_by_status[TestResult::TEST_FAILURE_ON_EXIT].begin(),
              tests_by_status[TestResult::TEST_FAILURE_ON_EXIT].end(),
              "failed on exit");
   PrintTests(tests_by_status[TestResult::TEST_TIMEOUT].begin(),
              tests_by_status[TestResult::TEST_TIMEOUT].end(),
              "timed out");
   PrintTests(tests_by_status[TestResult::TEST_CRASH].begin(),
              tests_by_status[TestResult::TEST_CRASH].end(),
              "crashed");
   PrintTests(tests_by_status[TestResult::TEST_SKIPPED].begin(),
              tests_by_status[TestResult::TEST_SKIPPED].end(),
              "skipped");
   PrintTests(tests_by_status[TestResult::TEST_UNKNOWN].begin(),
              tests_by_status[TestResult::TEST_UNKNOWN].end(),
              "had unknown result");
 }
 
 void TestResultsTracker::PrintSummaryOfAllIterations() const {
   DCHECK(thread_checker_.CalledOnValidThread());
 
-  std::map<TestResult::Status, std::set<std::string> > tests_by_status;
-
-  for (int i = 0; i <= iteration_; i++) {
-    for (PerIterationData::ResultsMap::const_iterator j =
-             per_iteration_data_[i].results.begin();
-         j != per_iteration_data_[i].results.end();
-         ++j) {
-      // Use the last test result as the final one.
-      TestResult result = j->second.test_results.back();
-      tests_by_status[result.status].insert(result.full_name);
-    }
-  }
+  TestStatusMap tests_by_status(GetTestStatusMapForAllIterations());
 
   fprintf(stdout, "Summary of all test iterations:\n");
   fflush(stdout);
 
   PrintTests(tests_by_status[TestResult::TEST_FAILURE].begin(),
              tests_by_status[TestResult::TEST_FAILURE].end(),
              "failed");
   PrintTests(tests_by_status[TestResult::TEST_FAILURE_ON_EXIT].begin(),
              tests_by_status[TestResult::TEST_FAILURE_ON_EXIT].end(),
              "failed on exit");
@@ skipping 92 matching lines @@
         test_result_value->SetString("output_snippet_base64",
                                      base64_output_snippet);
       }
     }
   }
 
   JSONFileValueSerializer serializer(path);
   return serializer.Serialize(*summary_root);
 }
 
+TestResultsTracker::TestStatusMap
+    TestResultsTracker::GetTestStatusMapForCurrentIteration() const {
+  TestStatusMap tests_by_status;
+  GetTestStatusForIteration(iteration_, &tests_by_status);
+  return tests_by_status;
+}
+
+TestResultsTracker::TestStatusMap
+    TestResultsTracker::GetTestStatusMapForAllIterations() const {
+  TestStatusMap tests_by_status;
+  for (int i = 0; i <= iteration_; i++)
+    GetTestStatusForIteration(i, &tests_by_status);
+  return tests_by_status;
+}
+
+void TestResultsTracker::GetTestStatusForIteration(
+    int iteration, TestStatusMap* map) const {
+  for (PerIterationData::ResultsMap::const_iterator j =
+           per_iteration_data_[iteration].results.begin();
+       j != per_iteration_data_[iteration].results.end();
+       ++j) {
+    // Use the last test result as the final one.
+    const TestResult& result = j->second.test_results.back();
+    (*map)[result.status].insert(result.full_name);
+  }
+}
+
 TestResultsTracker::AggregateTestResult::AggregateTestResult() {
 }
 
 TestResultsTracker::AggregateTestResult::~AggregateTestResult() {
 }
 
 TestResultsTracker::PerIterationData::PerIterationData() {
 }
 
 TestResultsTracker::PerIterationData::~PerIterationData() {
 }
 
 }  // namespace base