Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3127)

Unified Diff: base/test/launcher/test_launcher.cc

Issue 316903003: Mark test results with unknown status as unreliable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: const Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/launcher/test_results_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/launcher/test_launcher.cc
diff --git a/base/test/launcher/test_launcher.cc b/base/test/launcher/test_launcher.cc
index 8d62afac53a26f9f529c3880a2bb329e95b4478d..c5348eb3f08e3b5ff01d8d306f639ca9ec4cf841 100644
--- a/base/test/launcher/test_launcher.cc
+++ b/base/test/launcher/test_launcher.cc
@@ -461,9 +461,6 @@ void TestLauncher::OnTestFinished(const TestResult& result) {
tests_to_retry_.insert(result.full_name);
}
- // TODO(phajdan.jr): Flag unreliable unknown results, unless passed on retry.
- // See http://crbug.com/381733 .
-
results_tracker_.AddTestResult(result);
// TODO(phajdan.jr): Align counter (padding).
@@ -881,6 +878,11 @@ void TestLauncher::OnLaunchTestProcessFinished(
}
void TestLauncher::OnTestIterationFinished() {
+ TestResultsTracker::TestStatusMap tests_by_status(
+ results_tracker_.GetTestStatusMapForCurrentIteration());
+ if (!tests_by_status[TestResult::TEST_UNKNOWN].empty())
+ results_tracker_.AddGlobalTag(kUnreliableResultsTag);
+
// When we retry tests, success is determined by having nothing more
// to retry (everything eventually passed), as opposed to having
// no failures at all.
« no previous file with comments | « no previous file | base/test/launcher/test_results_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698