Issue 316863003: Switch Blink to using new Skia SkCanvas::drawPicture method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316863003: Switch Blink to using new Skia SkCanvas::drawPicture method (Closed)

Created:
6 years, 6 months ago by robertphillips

Modified:
6 years, 6 months ago

Reviewers:
f(malita), fmalita_google_do_not_use

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Switch Blink to using new Skia SkCanvas::drawPicture method As of Skia 9b14f26d (Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) - https://codereview.chromium.org/313613004) SkCanvas::drawPicture has an alternate signature. The old entry point is deprecated. Note: this patch cannot be landed until the corresponding Skia change is rolled into Chromium & Blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175569

Patch Set 1 #

Patch Set 2 : Address code review comment (fix override in GraphicsContextRecorder) #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
M	Source/platform/graphics/DeferredImageDecoderTest.cpp	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/platform/graphics/GraphicsContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/GraphicsContextRecorder.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

f(malita)

We also need to update GraphicsContextRecorder.cpp (it tries to override drawPicture).

6 years, 6 months ago (2014-06-04 15:08:48 UTC) #2

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 6 months ago (2014-06-05 11:58:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertphillips@google.com/316863003/20001

6 years, 6 months ago (2014-06-05 11:59:03 UTC) #6

Message was sent while issue was closed.

Change committed as 175569

Expand Messages | Collapse Messages