Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 316863003: Switch Blink to using new Skia SkCanvas::drawPicture method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address code review comment (fix override in GraphicsContextRecorder) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/graphics/GraphicsContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/DeferredImageDecoderTest.cpp
diff --git a/Source/platform/graphics/DeferredImageDecoderTest.cpp b/Source/platform/graphics/DeferredImageDecoderTest.cpp
index 431b731767039159681b3d02d20a80095faef7ee..c4a953efa42b594fb724a140490cc58fde6106a9 100644
--- a/Source/platform/graphics/DeferredImageDecoderTest.cpp
+++ b/Source/platform/graphics/DeferredImageDecoderTest.cpp
@@ -162,7 +162,7 @@ TEST_F(DeferredImageDecoderTest, drawIntoSkPicture)
RefPtr<SkPicture> picture = adoptRef(recorder.endRecording());
EXPECT_EQ(0, m_frameBufferRequestCount);
- m_canvas->drawPicture(*picture);
+ m_canvas->drawPicture(picture.get());
EXPECT_EQ(0, m_frameBufferRequestCount);
SkBitmap canvasBitmap;
@@ -183,7 +183,7 @@ TEST_F(DeferredImageDecoderTest, drawIntoSkPictureProgressive)
SkCanvas* tempCanvas = recorder.beginRecording(100, 100, 0, 0);
tempCanvas->drawBitmap(image->bitmap(), 0, 0);
RefPtr<SkPicture> picture = adoptRef(recorder.endRecording());
- m_canvas->drawPicture(*picture);
+ m_canvas->drawPicture(picture.get());
// Fully received the file and draw the SkPicture again.
m_lazyDecoder->setData(*m_data, true);
@@ -191,7 +191,7 @@ TEST_F(DeferredImageDecoderTest, drawIntoSkPictureProgressive)
tempCanvas = recorder.beginRecording(100, 100, 0, 0);
tempCanvas->drawBitmap(image->bitmap(), 0, 0);
picture = adoptRef(recorder.endRecording());
- m_canvas->drawPicture(*picture);
+ m_canvas->drawPicture(picture.get());
SkBitmap canvasBitmap;
ASSERT_TRUE(canvasBitmap.allocN32Pixels(100, 100));
@@ -202,7 +202,7 @@ TEST_F(DeferredImageDecoderTest, drawIntoSkPictureProgressive)
static void rasterizeMain(SkCanvas* canvas, SkPicture* picture)
{
- canvas->drawPicture(*picture);
+ canvas->drawPicture(picture);
}
TEST_F(DeferredImageDecoderTest, decodeOnOtherThread)
@@ -325,7 +325,7 @@ TEST_F(DeferredImageDecoderTest, decodedSize)
tempCanvas->drawBitmap(image->bitmap(), 0, 0);
RefPtr<SkPicture> picture = adoptRef(recorder.endRecording());
EXPECT_EQ(0, m_frameBufferRequestCount);
- m_canvas->drawPicture(*picture);
+ m_canvas->drawPicture(picture.get());
EXPECT_EQ(1, m_frameBufferRequestCount);
}
« no previous file with comments | « no previous file | Source/platform/graphics/GraphicsContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698