Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: Source/platform/graphics/GraphicsContextRecorder.cpp

Issue 316863003: Switch Blink to using new Skia SkCanvas::drawPicture method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address code review comment (fix override in GraphicsContextRecorder) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/GraphicsContext.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/GraphicsContextRecorder.cpp
diff --git a/Source/platform/graphics/GraphicsContextRecorder.cpp b/Source/platform/graphics/GraphicsContextRecorder.cpp
index 02615de435184b81902e47fee8b0ae3087c9a66d..e22ae878e73537d03ebf5f540ce259ffa3311c52 100644
--- a/Source/platform/graphics/GraphicsContextRecorder.cpp
+++ b/Source/platform/graphics/GraphicsContextRecorder.cpp
@@ -202,11 +202,6 @@ public:
params->setObject("paint", objectForSkPaint(paint));
}
- void drawPicture(SkPicture& picture) OVERRIDE
- {
- addItemWithParams("drawPicture")->setObject("picture", objectForSkPicture(picture));
- }
-
void drawRect(const SkRect& rect, const SkPaint& paint) OVERRIDE
{
RefPtr<JSONObject> params = addItemWithParams("drawRect");
@@ -397,6 +392,11 @@ public:
params->setString("op", regionOpName(op));
}
+ void onDrawPicture(const SkPicture* picture) OVERRIDE
+ {
+ addItemWithParams("drawPicture")->setObject("picture", objectForSkPicture(*picture));
+ }
+
void didSetMatrix(const SkMatrix& matrix) OVERRIDE
{
RefPtr<JSONObject> params = addItemWithParams("setMatrix");
« no previous file with comments | « Source/platform/graphics/GraphicsContext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698