Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 315843004: Oilpan: Replace RefPtrs to Node and its subclasses in core/html with Oilpan transitin types. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, nessy, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, vcarbune.chromium, philipj_slow
Visibility:
Public.

Description

Oilpan: Replace RefPtrs to Node and its subclasses in core/html with Oilpan transitin types. This CL also declares VTTTreeBuilder as STACK_ALLOCATED and makes m_currentNode and m_document traceable. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175467

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-04 07:04:25 UTC) #1
haraken
LGTM https://codereview.chromium.org/315843004/diff/1/Source/core/html/HTMLTableElement.cpp File Source/core/html/HTMLTableElement.cpp (right): https://codereview.chromium.org/315843004/diff/1/Source/core/html/HTMLTableElement.cpp#newcode217 Source/core/html/HTMLTableElement.cpp:217: RefPtrWillBeRawPtr<ContainerNode> parent; = nullptr https://codereview.chromium.org/315843004/diff/1/Source/core/html/track/vtt/VTTCue.cpp File Source/core/html/track/vtt/VTTCue.cpp (right): ...
6 years, 6 months ago (2014-06-04 07:06:16 UTC) #2
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-04 07:07:30 UTC) #3
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-04 07:41:50 UTC) #4
tkent
https://codereview.chromium.org/315843004/diff/1/Source/core/html/HTMLTableElement.cpp File Source/core/html/HTMLTableElement.cpp (right): https://codereview.chromium.org/315843004/diff/1/Source/core/html/HTMLTableElement.cpp#newcode217 Source/core/html/HTMLTableElement.cpp:217: RefPtrWillBeRawPtr<ContainerNode> parent; On 2014/06/04 07:06:16, haraken wrote: > > ...
6 years, 6 months ago (2014-06-04 08:03:25 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-04 08:03:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/315843004/20001
6 years, 6 months ago (2014-06-04 08:04:21 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 09:37:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 10:03:11 UTC) #9
Message was sent while issue was closed.
Change committed as 175467

Powered by Google App Engine
This is Rietveld 408576698