Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 315573003: Remove PermissionsData::ForExtension() completely (Closed)

Created:
6 years, 6 months ago by Devlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), vsevik, extensions-reviews_chromium.org, Lei Zhang, yurys, tommycli, paulirish+reviews_chromium.org, Greg Billock, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, miu+watch_chromium.org
Visibility:
Public.

Description

Remove PermissionsData::ForExtension() completely There's no reason to have this. It was originally because PermissionsData didn't really belong on Extension (and was to be taken off), but now that PermissionsData is refactored to only include active permissions, it belongs on the extension object. TBR=ben@chromium.org (c/b/ui - simple refactor, no functional changes) TBR=thestig@chromium.org (c/b/media_galleries - simple refactor, no functional changes) BUG=379356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275332

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -316 lines) Patch
M chrome/browser/apps/ephemeral_app_launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/active_tab_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 3 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_helpers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/hid/hid_api.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 4 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/location_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 10 chunks +11 lines, -12 lines 0 comments Download
M chrome/common/extensions/permissions/settings_override_permission_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 1 7 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/common/extension.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/extension_messages.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/features/permission_feature.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/common/permissions/permissions_data_unittest.cc View 22 chunks +55 lines, -88 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_injection.cc View 1 2 chunks +10 lines, -12 lines 0 comments Download
M extensions/renderer/user_script_scheduler.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Devlin
No functional changes.
6 years, 6 months ago (2014-06-05 17:50:49 UTC) #1
not at google - send to devlin
i don't see any changes to permissions_data.*? https://codereview.chromium.org/315573003/diff/40001/extensions/common/extension.cc File extensions/common/extension.cc (right): https://codereview.chromium.org/315573003/diff/40001/extensions/common/extension.cc#newcode291 extensions/common/extension.cc:291: return this->permissions_data()->HasAPIPermission(permission); ...
6 years, 6 months ago (2014-06-05 17:52:56 UTC) #2
Devlin
On 2014/06/05 17:52:56, kalman wrote: > i don't see any changes to permissions_data.*? Hmm... git ...
6 years, 6 months ago (2014-06-05 18:11:43 UTC) #3
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-05 18:12:59 UTC) #4
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-05 19:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/315573003/60001
6 years, 6 months ago (2014-06-05 19:59:46 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 00:02:37 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:04:43 UTC) #8
Message was sent while issue was closed. 
Change committed as 275332

Powered by Google App Engine
This is Rietveld 408576698