Remove PermissionsData::ForExtension() completely

extensions/common/extension.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 270 matching lines @@
   return true;
 }
 
 // static
 GURL Extension::GetBaseURLFromExtensionId(const std::string& extension_id) {
   return GURL(std::string(extensions::kExtensionScheme) +
               url::kStandardSchemeSeparator + extension_id + "/");
 }
 
 bool Extension::HasAPIPermission(APIPermission::ID permission) const {
-  return PermissionsData::ForExtension(this)->HasAPIPermission(permission);
+  return this->permissions_data()->HasAPIPermission(permission);

[not at google - send to devlin, 2014/06/05 17:52:56]

take out |this|

[Devlin, 2014/06/05 18:11:43]

Alas, the limitations of sed.  Done.

 }
 
 bool Extension::HasAPIPermission(const std::string& permission_name) const {
-  return PermissionsData::ForExtension(this)->HasAPIPermission(permission_name);
+  return this->permissions_data()->HasAPIPermission(permission_name);
 }
 
 scoped_refptr<const PermissionSet> Extension::GetActivePermissions() const {
-  return PermissionsData::ForExtension(this)->active_permissions();
+  return this->permissions_data()->active_permissions();
 }
 
 bool Extension::ShowConfigureContextMenus() const {
   // Don't show context menu for component extensions. We might want to show
   // options for component extension button but now there is no component
   // extension with options. All other menu items like uninstall have
   // no sense for component extensions.
   return location() != Manifest::COMPONENT &&
          location() != Manifest::EXTERNAL_COMPONENT;
 }
@@ skipping 478 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions