chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 315573003: Remove PermissionsData::ForExtension() completely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 315573003: Remove PermissionsData::ForExtension() completely (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index 5e3bbddd37f64fb42da1a9b62cafdc7982782b2d..8a71d567653cd1638645056b894de8ececb0d4fe 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -170,12 +170,11 @@ class IsPageActionViewRightAligned {

: extension_service_(extension_service) {}

bool operator()(PageActionWithBadgeView* page_action_view) {

- return extensions::PermissionsData::ForExtension(

- extension_service_->GetExtensionById(

- page_action_view->image_view()

- ->page_action()

- ->extension_id(),

- false))

+ return extension_service_

+ ->GetExtensionById(

+ page_action_view->image_view()->page_action()->extension_id(),

+ false)

+ ->permissions_data()

->HasAPIPermission(extensions::APIPermission::kBookmarkManagerPrivate);

}