Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 315023003: ServiceWorker: Read the blob from SW's response to a fetch event (Closed)

Created:
6 years, 6 months ago by falken
Modified:
6 years, 6 months ago
Reviewers:
michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Read the blob from SW's response to a fetch event Also remove browser tests for the fetch event that will be replaced with layout tests in the next Blink patch. Since layout tests can't test HTTP response headers, one of the browser tests remains. Multi-sided patch to implement blob-type fetch event response bodies: 1: blink-side: https://codereview.chromium.org/307063002/ 2: chromium-side, THIS PATCH 3: blink-side: https://codereview.chromium.org/304233017 Originally landed in r274773 and reverted in r274799 for breaking ASAN. Relanding after fixing a buffer overflow caused by using the wrong std::string ctor. BUG=379074 TBR=michaeln Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274915

Patch Set 1 #

Patch Set 2 : fix use of wrong ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -35 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 4 chunks +21 lines, -15 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/service_worker/fetch_event.js View 1 chunk +2 lines, -1 line 0 comments Download
D content/test/data/service_worker/fetch_event_error.js View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/service_worker/fetch_event_fallback.js View 1 chunk +0 lines, -8 lines 0 comments Download
M content/test/data/service_worker/sync.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
Michael, I'm relanding this after a simple fix. Patchset 1 is the original (https://codereview.chromium.org/304153015/) which ...
6 years, 6 months ago (2014-06-04 14:13:37 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 6 months ago (2014-06-04 14:14:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/315023003/20001
6 years, 6 months ago (2014-06-04 14:18:34 UTC) #3
michaeln
lgtm
6 years, 6 months ago (2014-06-04 20:15:56 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 21:52:37 UTC) #5
Message was sent while issue was closed.
Change committed as 274915

Powered by Google App Engine
This is Rietveld 408576698