Issue 304153015: ServiceWorker: Read the blob from SW's response to a fetch event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304153015: ServiceWorker: Read the blob from SW's response to a fetch event (Closed)

Created:
6 years, 6 months ago by falken

Modified:
6 years, 6 months ago

Reviewers:
michaeln

CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ServiceWorker: Read the blob from SW's response to a fetch event Also remove browser tests for the fetch event that will be replaced with layout tests in the next Blink patch. Since layout tests can't test HTTP response headers, one of the browser tests remains. Multi-sided patch to implement blob-type fetch event response bodies: #1: blink-side: https://codereview.chromium.org/307063002/ #2: chromium-side, THIS PATCH #3: blink-side: https://codereview.chromium.org/304233017 BUG=379074 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274773

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -35 lines)			Patch
M	content/browser/service_worker/service_worker_browsertest.cc	View	4 chunks	+22 lines, -15 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_context_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/data/service_worker/fetch_event.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	content/test/data/service_worker/fetch_event_error.js	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	content/test/data/service_worker/fetch_event_fallback.js	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	content/test/data/service_worker/sync.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/304153015/1

6 years, 6 months ago (2014-06-04 00:12:41 UTC) #4

Message was sent while issue was closed.

Change committed as 274773

Expand Messages | Collapse Messages