Issue 3145014: Include ICU headers in a way that will also work with use_system_icu=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3145014: Include ICU headers in a way that will also work with use_system_icu=1 (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Stephen White, jungshik at Google, Evan Martin

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Include ICU headers in a way that will also work with use_system_icu=1 TEST=none BUG=28294 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56396

Patch Set 1 #

Patch Set 2 : rebase #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -14 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_popup_model.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/input_method_library.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_worditerator.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_worditerator.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	skia/ext/SkFontHost_fontconfig_direct.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

I'm concerned that these forms of includes will accidentally end up using the system ICU, ...

10 years, 4 months ago (2010-08-13 21:54:50 UTC) #2

Evan Martin

10 years, 4 months ago (2010-08-17 00:56:58 UTC) #3

We talked about this on IRC, and we found that Chrome is already doing the form
of #include I was worrying about all over the place.  So I think my worry is
overstated.

LGTM

Expand Messages | Collapse Messages