Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_popup_model.cc

Issue 3145014: Include ICU headers in a way that will also work with use_system_icu=1 (Closed)
Patch Set: rebase Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/input_method_library.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/autocomplete_popup_model.h" 5 #include "chrome/browser/autocomplete/autocomplete_popup_model.h"
6 6
7 #include "unicode/ubidi.h"
8
7 #include "base/string_util.h" 9 #include "base/string_util.h"
8 #include "chrome/browser/autocomplete/autocomplete_edit.h" 10 #include "chrome/browser/autocomplete/autocomplete_edit.h"
9 #include "chrome/browser/autocomplete/autocomplete_popup_view.h" 11 #include "chrome/browser/autocomplete/autocomplete_popup_view.h"
10 #include "chrome/browser/profile.h" 12 #include "chrome/browser/profile.h"
11 #include "chrome/browser/extensions/extensions_service.h" 13 #include "chrome/browser/extensions/extensions_service.h"
12 #include "chrome/browser/search_engines/template_url.h" 14 #include "chrome/browser/search_engines/template_url.h"
13 #include "chrome/browser/search_engines/template_url_model.h" 15 #include "chrome/browser/search_engines/template_url_model.h"
14 #include "chrome/common/notification_service.h" 16 #include "chrome/common/notification_service.h"
15 #include "third_party/icu/public/common/unicode/ubidi.h"
16 17
17 /////////////////////////////////////////////////////////////////////////////// 18 ///////////////////////////////////////////////////////////////////////////////
18 // AutocompletePopupModel 19 // AutocompletePopupModel
19 20
20 AutocompletePopupModel::AutocompletePopupModel( 21 AutocompletePopupModel::AutocompletePopupModel(
21 AutocompletePopupView* popup_view, 22 AutocompletePopupView* popup_view,
22 AutocompleteEditModel* edit_model, 23 AutocompleteEditModel* edit_model,
23 Profile* profile) 24 Profile* profile)
24 : view_(popup_view), 25 : view_(popup_view),
25 edit_model_(edit_model), 26 edit_model_(edit_model),
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 } 294 }
294 295
295 const SkBitmap* AutocompletePopupModel::GetSpecialIconForMatch( 296 const SkBitmap* AutocompletePopupModel::GetSpecialIconForMatch(
296 const AutocompleteMatch& match) const { 297 const AutocompleteMatch& match) const {
297 if (!match.template_url || !match.template_url->IsExtensionKeyword()) 298 if (!match.template_url || !match.template_url->IsExtensionKeyword())
298 return NULL; 299 return NULL;
299 300
300 return &profile_->GetExtensionsService()->GetOmniboxIcon( 301 return &profile_->GetExtensionsService()->GetOmniboxIcon(
301 match.template_url->GetExtensionId()); 302 match.template_url->GetExtensionId());
302 } 303 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/input_method_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698