chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc - Issue 3145014: Include ICU headers in a way that will also work with use_system_icu=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

Issue 3145014: Include ICU headers in a way that will also work with use_system_icu=1 (Closed)

Patch Set: rebase Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | chrome/renderer/spellchecker/spellcheck_worditerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

diff --git a/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc b/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

index f3290f16029834e30c58d2df36132d1fb19bb21c..e8baee1299c0601b2abc5d734aed2663b39ebc91 100644

--- a/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

+++ b/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h"

+#include "unicode/ubidi.h"

#include "app/bidi_line_iterator.h"

#include "app/l10n_util.h"

#include "app/resource_bundle.h"

@@ -22,7 +24,6 @@

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "third_party/skia/include/core/SkShader.h"

-#include "third_party/icu/public/common/unicode/ubidi.h"

#include "views/widget/widget.h"

#if defined(OS_WIN)