Issue 314113009: Omnibox Metrics: Make |completed_length| field sane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314113009: Omnibox Metrics: Make |completed_length| field sane (Closed)

Created:
6 years, 6 months ago by Mark P

Modified:
6 years, 6 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Omnibox Metrics: Make |completed_length| field sane Have no qualms about fixing the definition of this broken field. (No need to deprecate the field and create a new one.) See bug link for details. The internal proto change has been submitted. TBR=pkasting BUG=381650 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275651

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -5 lines)			Patch
M	chrome/browser/omnibox/omnibox_log.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_edit_model.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	components/metrics/proto/omnibox_event.proto	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark P

Internal change has been submitted. Now submitting this. --mark

6 years, 6 months ago (2014-06-06 23:26:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/314113009/1

6 years, 6 months ago (2014-06-06 23:30:30 UTC) #5

Message was sent while issue was closed.

Change committed as 275651

Expand Messages | Collapse Messages