chrome/browser/ui/omnibox/omnibox_edit_model.cc - Issue 314113009: Omnibox Metrics: Make |completed_length| field sane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 314113009: Omnibox Metrics: Make |completed_length| field sane (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

index cbca6240bba7a630bb689869f37effd2fb43b1ca..1f6de5b89b38a3358cc9f408c0927d8564cd9cb5 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

@@ -751,7 +751,8 @@ void OmniboxEditModel::OpenMatch(AutocompleteMatch match,

-1, // don't yet know tab ID; set later if appropriate

ClassifyPage(),

elapsed_time_since_user_first_modified_omnibox,

- match.inline_autocompletion.length(),

+ match.allowed_to_be_default_match ? match.inline_autocompletion.length() :

+ base::string16::npos,

elapsed_time_since_last_change_to_default_match,

(!popup_model()->IsOpen() || !pasted_text.empty()) ?

fake_single_entry_result : result());

« no previous file with comments | « chrome/browser/omnibox/omnibox_log.h ('k') | components/metrics/proto/omnibox_event.proto » ('j') | no next file with comments »