Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: components/metrics/proto/omnibox_event.proto

Issue 314113009: Omnibox Metrics: Make |completed_length| field sane (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // dropdown is closed when logging these. 48 // dropdown is closed when logging these.
49 optional bool is_popup_open = 15; 49 optional bool is_popup_open = 15;
50 50
51 // True if this is a paste-and-search or paste-and-go action. (The codebase 51 // True if this is a paste-and-search or paste-and-go action. (The codebase
52 // refers to both these types as paste-and-go.) 52 // refers to both these types as paste-and-go.)
53 optional bool is_paste_and_go = 16; 53 optional bool is_paste_and_go = 16;
54 54
55 // The length of the inline autocomplete text in the omnibox. 55 // The length of the inline autocomplete text in the omnibox.
56 // The sum |typed_length| + |completed_length| gives the full length of the 56 // The sum |typed_length| + |completed_length| gives the full length of the
57 // user-visible text in the omnibox. 57 // user-visible text in the omnibox.
58 // This field is only set for inlineable suggestions selected at position 0 58 // This field is only set for suggestions that are allowed to be the default
59 // (|selected_index| = 0) and will be omitted otherwise. 59 // match and omitted otherwise. The first suggestion is always allowed to
60 // be the default match. (This is an enforced constraint.) Hence, if
61 // |selected_index| == 0, then this field will always be set.
60 optional int32 completed_length = 6; 62 optional int32 completed_length = 6;
61 63
62 // The amount of time, in milliseconds, since the user first began modifying 64 // The amount of time, in milliseconds, since the user first began modifying
63 // the text in the omnibox. If at some point after modifying the text, the 65 // the text in the omnibox. If at some point after modifying the text, the
64 // user reverts the modifications (thus seeing the current web page's URL 66 // user reverts the modifications (thus seeing the current web page's URL
65 // again), then writes in the omnibox again, this elapsed time should start 67 // again), then writes in the omnibox again, this elapsed time should start
66 // from the time of the second series of modification. 68 // from the time of the second series of modification.
67 optional int64 typing_duration_ms = 7; 69 optional int64 typing_duration_ms = 7;
68 70
69 // The amount of time, in milliseconds, since the last time the default 71 // The amount of time, in milliseconds, since the last time the default
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 // The number of times this provider returned a non-zero number of 261 // The number of times this provider returned a non-zero number of
260 // suggestions during this omnibox session. 262 // suggestions during this omnibox session.
261 // Note that each provider may define a session differently for its 263 // Note that each provider may define a session differently for its
262 // purposes. 264 // purposes.
263 optional int32 times_returned_results_in_session = 5; 265 optional int32 times_returned_results_in_session = 5;
264 } 266 }
265 // A list of diagnostic information about each provider. Providers 267 // A list of diagnostic information about each provider. Providers
266 // will appear at most once in this list. 268 // will appear at most once in this list.
267 repeated ProviderInfo provider_info = 12; 269 repeated ProviderInfo provider_info = 12;
268 } 270 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698