Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified (Closed)

Created:
6 years, 6 months ago by mdempsky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified POSIX specifies that using O_TRUNC without O_RDWR or O_WRONLY is undefined behavior. BUG=380954 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276097

Patch Set 1 #

Patch Set 2 : Fix PlatformFile.CreatePlatformFile test #

Total comments: 2

Patch Set 3 : Require FLAG_WRITE on Windows too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/files/file_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/platform_file_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
mdempsky
6 years, 6 months ago (2014-06-05 17:12:24 UTC) #1
rvargas (doing something else)
https://codereview.chromium.org/314023002/diff/20001/base/files/file_posix.cc File base/files/file_posix.cc (right): https://codereview.chromium.org/314023002/diff/20001/base/files/file_posix.cc#newcode186 base/files/file_posix.cc:186: DCHECK(flags & FLAG_WRITE); We should keep the behavior consistent ...
6 years, 6 months ago (2014-06-05 19:27:53 UTC) #2
mdempsky
https://codereview.chromium.org/314023002/diff/20001/base/files/file_posix.cc File base/files/file_posix.cc (right): https://codereview.chromium.org/314023002/diff/20001/base/files/file_posix.cc#newcode186 base/files/file_posix.cc:186: DCHECK(flags & FLAG_WRITE); On 2014/06/05 19:27:52, rvargas wrote: > ...
6 years, 6 months ago (2014-06-09 17:56:22 UTC) #3
darin (slow to review)
LGTM
6 years, 6 months ago (2014-06-09 18:05:25 UTC) #4
rvargas (doing something else)
LGTM
6 years, 6 months ago (2014-06-09 18:07:18 UTC) #5
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 6 months ago (2014-06-09 18:55:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/314023002/40001
6 years, 6 months ago (2014-06-09 18:56:08 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 08:56:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 11:54:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/160977)
6 years, 6 months ago (2014-06-10 11:54:44 UTC) #10
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 6 months ago (2014-06-10 18:05:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/314023002/40001
6 years, 6 months ago (2014-06-10 18:09:54 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 18:38:00 UTC) #13
Message was sent while issue was closed. 
Change committed as 276097

Powered by Google App Engine
This is Rietveld 408576698