base/files/file_win.cc - Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_win.cc

Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Require FLAG_WRITE on Windows too Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_win.cc

diff --git a/base/files/file_win.cc b/base/files/file_win.cc

index 1e13381e255f00be678f0c224b933b729bd47ab8..9e18bda70b1c93b68f6b1983e4772e16b96fbed0 100644

--- a/base/files/file_win.cc

+++ b/base/files/file_win.cc

@@ -34,6 +34,7 @@ void File::InitializeUnsafe(const FilePath& name, uint32 flags) {

if (flags & FLAG_CREATE_ALWAYS) {

DCHECK(!disposition);

+ DCHECK(flags & FLAG_WRITE);

disposition = CREATE_ALWAYS;

}

« no previous file with comments | « base/files/file_unittest.cc ('k') | base/platform_file_unittest.cc » ('j') | no next file with comments »