base/platform_file_unittest.cc - Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_file_unittest.cc

Issue 314023002: Require FLAG_WRITE when FLAG_CREATE_ALWAYS is specified (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Require FLAG_WRITE on Windows too Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_file_unittest.cc

diff --git a/base/platform_file_unittest.cc b/base/platform_file_unittest.cc

index 80883832bb98e218b802b67315d93d3e45b64a32..70058ea4ebf144fc41851461decdd90676110853 100644

--- a/base/platform_file_unittest.cc

+++ b/base/platform_file_unittest.cc

@@ -101,7 +101,7 @@ TEST(PlatformFile, CreatePlatformFile) {

error_code = PLATFORM_FILE_OK;

file = CreatePlatformFile(

file_path,

- PLATFORM_FILE_CREATE_ALWAYS | PLATFORM_FILE_READ,

+ PLATFORM_FILE_CREATE_ALWAYS | PLATFORM_FILE_WRITE,

&created,

&error_code);

EXPECT_NE(kInvalidPlatformFileValue, file);

« no previous file with comments | « base/files/file_win.cc ('k') | no next file » | no next file with comments »