Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 313613002: Remove legacy picture recording (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove legacy picture recording This is unblocked now that Android no longer uses the old interface. This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio. Committed: https://skia.googlesource.com/skia/+/dcf9ab14a194be0cbea896e1dc44a2a04106a38b

Patch Set 1 #

Patch Set 2 : remove dead files #

Patch Set 3 : Remove dead files from core.gypi #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -470 lines) Patch
M gyp/core.gypi View 1 2 4 chunks +0 lines, -5 lines 0 comments Download
M include/core/SkPicture.h View 5 chunks +28 lines, -89 lines 1 comment Download
M include/core/SkPictureRecorder.h View 2 chunks +0 lines, -33 lines 2 comments Download
M include/core/SkRTreePicture.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
M include/core/SkTileGridPicture.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
M src/core/SkPicture.cpp View 5 chunks +3 lines, -64 lines 0 comments Download
M src/core/SkQuadTreePicture.h View 1 1 chunk +0 lines, -50 lines 0 comments Download
M src/core/SkQuadTreePicture.cpp View 1 1 chunk +0 lines, -18 lines 0 comments Download
M src/core/SkRTreePicture.cpp View 1 1 chunk +0 lines, -28 lines 0 comments Download
M src/core/SkTileGridPicture.cpp View 1 1 chunk +0 lines, -33 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-03 15:03:43 UTC) #1
reed1
lgtm but others should chime-in https://codereview.chromium.org/313613002/diff/40001/include/core/SkPictureRecorder.h File include/core/SkPictureRecorder.h (right): https://codereview.chromium.org/313613002/diff/40001/include/core/SkPictureRecorder.h#newcode46 include/core/SkPictureRecorder.h:46: ref which the caller ...
6 years, 6 months ago (2014-06-03 15:14:03 UTC) #2
mtklein
SO lgtm https://codereview.chromium.org/313613002/diff/40001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/313613002/diff/40001/include/core/SkPicture.h#newcode136 include/core/SkPicture.h:136: // SkPicture. It should be moved to ...
6 years, 6 months ago (2014-06-03 15:27:43 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-03 15:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/313613002/40001
6 years, 6 months ago (2014-06-03 15:34:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 16:10:20 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 6 months ago (2014-06-03 16:10:20 UTC) #7
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-03 17:04:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/313613002/40001
6 years, 6 months ago (2014-06-03 17:04:39 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 17:04:51 UTC) #10
Message was sent while issue was closed. 
Change committed as dcf9ab14a194be0cbea896e1dc44a2a04106a38b

Powered by Google App Engine
This is Rietveld 408576698