Source/web/WebViewImpl.cpp - Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Extracting paintCompositionBackgrounds() from paint(). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 51c45460b378c2f15239fceba6f3b17969307127..52ef8c571783c493f37a82e25ffb747565b89763 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2340,7 +2340,7 @@ WebVector<WebCompositionUnderline> WebViewImpl::compositionUnderlines() const

WebVector<WebCompositionUnderline> results(underlines.size());

for (size_t index = 0; index < underlines.size(); ++index) {

CompositionUnderline underline = underlines[index];

- results[index] = WebCompositionUnderline(underline.startOffset, underline.endOffset, static_cast<WebColor>(underline.color.rgb()), underline.thick);

+ results[index] = WebCompositionUnderline(underline.startOffset, underline.endOffset, static_cast<WebColor>(underline.color.rgb()), underline.thick, static_cast<WebColor>(underline.backgroundColor.rgb()));

}

return results;

}

« no previous file with comments | « Source/web/CompositionUnderlineBuilder.h ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »