Source/web/CompositionUnderlineBuilder.h - Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/CompositionUnderlineBuilder.h

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Extracting paintCompositionBackgrounds() from paint(). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/CompositionUnderlineBuilder.h

diff --git a/Source/web/CompositionUnderlineBuilder.h b/Source/web/CompositionUnderlineBuilder.h

index f957a424278a32465bfaeb8f806b78cc2333eb50..950986e7751677681a0863c2b55abc1c5f40cf28 100644

--- a/Source/web/CompositionUnderlineBuilder.h

+++ b/Source/web/CompositionUnderlineBuilder.h

@@ -45,7 +45,8 @@ class CompositionUnderlineBuilder : public WebCore::CompositionUnderline {

public:

CompositionUnderlineBuilder(const WebCompositionUnderline& u)

: WebCore::CompositionUnderline(u.startOffset, u.endOffset,

- WebCore::Color(u.color), u.thick) { }

+ WebCore::Color(u.color), u.thick,

+ WebCore::Color(u.backgroundColor)) { }

};

} // namespace blink

« no previous file with comments | « Source/core/rendering/RenderTheme.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »