Source/web/tests/WebViewTest.cpp - Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebViewTest.cpp

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Extracting paintCompositionBackgrounds() from paint(). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebViewTest.cpp

diff --git a/Source/web/tests/WebViewTest.cpp b/Source/web/tests/WebViewTest.cpp

index e18e7ac52264779e7eb95c31326cc494d5030c05..0ae864e9893344f9c3a7154aa055d6921c43c326 100644

--- a/Source/web/tests/WebViewTest.cpp

+++ b/Source/web/tests/WebViewTest.cpp

@@ -642,7 +642,7 @@ TEST_F(WebViewTest, SetCompositionFromExistingText)

WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "input_field_populated.html");

webView->setInitialFocus(false);

WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));

- underlines[0] = blink::WebCompositionUnderline(0, 4, 0, false);

+ underlines[0] = blink::WebCompositionUnderline(0, 4, 0, false, 0);

WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());

frame->setEditableSelectionOffsets(4, 10);

frame->setCompositionFromExistingText(8, 12, underlines);

@@ -669,7 +669,7 @@ TEST_F(WebViewTest, SetCompositionFromExistingTextInTextArea)

WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "text_area_populated.html");

webView->setInitialFocus(false);

WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));

- underlines[0] = blink::WebCompositionUnderline(0, 4, 0, false);

+ underlines[0] = blink::WebCompositionUnderline(0, 4, 0, false, 0);

WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());

frame->setEditableSelectionOffsets(27, 27);

std::string newLineText("\n");

« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | public/web/WebCompositionUnderline.h » ('j') | no next file with comments »