Source/core/rendering/RenderTheme.h - Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTheme.h

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Extracting paintCompositionBackgrounds() from paint(). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTheme.h

diff --git a/Source/core/rendering/RenderTheme.h b/Source/core/rendering/RenderTheme.h

index a3ec3f66fed625cdb9eda8407b8b0675a0cc0a37..0ec13a3b4f2fad64f376efa1bacec480a2f29968 100644

--- a/Source/core/rendering/RenderTheme.h

+++ b/Source/core/rendering/RenderTheme.h

@@ -141,6 +141,7 @@ public:

void setCustomFocusRingColor(const Color&);

static Color tapHighlightColor();

virtual Color platformTapHighlightColor() const { return RenderTheme::defaultTapHighlightColor; }

+ virtual Color platformDefaultCompositionBackgroundColor() const { return defaultCompositionBackgroundColor; }

virtual void platformColorsDidChange();

virtual double caretBlinkInterval() const { return 0.5; }

@@ -306,6 +307,8 @@ private:

// making it more transparent than its alpha value indicates.

static const RGBA32 defaultTapHighlightColor = 0x66000000;

+ static const RGBA32 defaultCompositionBackgroundColor = 0xFFFFDD55;

#if USE(NEW_THEME)

Theme* m_platformTheme; // The platform-specific theme.

#endif

« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/web/CompositionUnderlineBuilder.h » ('j') | no next file with comments »