Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm64.cc (revision 37007)
+++ runtime/vm/flow_graph_compiler_arm64.cc (working copy)
@@ -1238,19 +1238,10 @@
ASSERT(!arguments_descriptor.IsNull() && (arguments_descriptor.Length() > 0));
const MegamorphicCache& cache =
MegamorphicCache::ZoneHandle(table->Lookup(name, arguments_descriptor));
- Label not_smi, load_cache;
__ LoadFromOffset(R0, SP, (argument_count - 1) * kWordSize, PP);
- __ tsti(R0, kSmiTagMask);
- __ b(&not_smi, NE);
- __ LoadImmediate(R0, Smi::RawValue(kSmiCid), PP);
- __ b(&load_cache);
+ __ LoadTaggedClassIdMayBeSmi(R0, R0);
- __ Bind(&not_smi);
- __ LoadClassId(R0, R0, PP);
- __ SmiTag(R0);
-
// R0: class ID of the receiver (smi).
- __ Bind(&load_cache);
__ LoadObject(R1, cache, PP);
__ LoadFieldFromOffset(R2, R1, MegamorphicCache::buckets_offset(), PP);
__ LoadFieldFromOffset(R1, R1, MegamorphicCache::mask_offset(), PP);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698