runtime/vm/flow_graph_compiler_arm.cc - Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_arm.cc

===================================================================

--- runtime/vm/flow_graph_compiler_arm.cc (revision 37007)

+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)

@@ -1232,16 +1232,10 @@

ASSERT(!arguments_descriptor.IsNull() && (arguments_descriptor.Length() > 0));

const MegamorphicCache& cache =

MegamorphicCache::ZoneHandle(table->Lookup(name, arguments_descriptor));

- Label not_smi, load_cache;

__ LoadFromOffset(kWord, R0, SP, (argument_count - 1) * kWordSize);

- __ tst(R0, Operand(kSmiTagMask));

- __ LoadClassId(R0, R0, NE);

- __ SmiTag(R0, NE);

- __ mov(R0, Operand(Smi::RawValue(kSmiCid)), EQ);

- __ b(&load_cache, EQ);

+ __ LoadTaggedClassIdMayBeSmi(R0, R0);

// R0: class ID of the receiver (smi).

- __ Bind(&load_cache);

__ LoadObject(R1, cache);

__ ldr(R2, FieldAddress(R1, MegamorphicCache::buckets_offset()));

__ ldr(R1, FieldAddress(R1, MegamorphicCache::mask_offset()));

« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »