Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 37007)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -1279,17 +1279,10 @@
ASSERT(!arguments_descriptor.IsNull() && (arguments_descriptor.Length() > 0));
const MegamorphicCache& cache =
MegamorphicCache::ZoneHandle(table->Lookup(name, arguments_descriptor));
- Label not_smi, load_cache;
+ Label load_cache;
__ movl(EAX, Address(ESP, (argument_count - 1) * kWordSize));
- __ testl(EAX, Immediate(kSmiTagMask));
- __ j(NOT_ZERO, &not_smi, Assembler::kNearJump);
- __ movl(EAX, Immediate(Smi::RawValue(kSmiCid)));
- __ jmp(&load_cache);
+ __ LoadTaggedClassIdMayBeSmi(EAX, EAX);
- __ Bind(&not_smi);
- __ LoadClassId(EAX, EAX);
- __ SmiTag(EAX);
-
// EAX: class ID of the receiver (smi).
__ Bind(&load_cache);
__ LoadObject(EBX, cache);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698