Issue 312683004: JNI bindings for GCMDriverAndroid

Issue 312683004: JNI bindings for GCMDriverAndroid (Closed)

Created:
6 years, 6 months ago by johnme

Modified:
6 years, 6 months ago

Reviewers:
fgorski, Michael van Ouwerkerk

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

JNI bindings for GCMDriverAndroid Bidirectional plumbing between C++ and Java. BUG=350378 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274667

Patch Set 2 : Renamed OnMessagesDeletedByServer #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -17 lines)			Patch
M	components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java	View	1	1 chunk	+82 lines, -5 lines	2 comments	Download
M	components/gcm_driver/gcm_driver_android.h	View	1	2 chunks	+24 lines, -1 line	0 comments	Download
M	components/gcm_driver/gcm_driver_android.cc	View	1	3 chunks	+84 lines, -11 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

fgorski

lgtm mod the name of function https://codereview.chromium.org/312683004/diff/1/components/gcm_driver/gcm_driver_android.h File components/gcm_driver/gcm_driver_android.h (right): https://codereview.chromium.org/312683004/diff/1/components/gcm_driver/gcm_driver_android.h#newcode60 components/gcm_driver/gcm_driver_android.h:60: void OnMessagesDeletedByServer(JNIEnv* env, ...

6 years, 6 months ago (2014-06-03 17:38:25 UTC) #2

johnme

Thanks for the quick review! Done. https://codereview.chromium.org/312683004/diff/1/components/gcm_driver/gcm_driver_android.h File components/gcm_driver/gcm_driver_android.h (right): https://codereview.chromium.org/312683004/diff/1/components/gcm_driver/gcm_driver_android.h#newcode60 components/gcm_driver/gcm_driver_android.h:60: void OnMessagesDeletedByServer(JNIEnv* env, ...

6 years, 6 months ago (2014-06-03 17:50:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/312683004/20001

6 years, 6 months ago (2014-06-03 17:52:10 UTC) #5

Michael van Ouwerkerk

Just some nits. https://codereview.chromium.org/312683004/diff/20001/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java File components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java (right): https://codereview.chromium.org/312683004/diff/20001/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java#newcode23 components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java:23: private Context mContext; final? https://codereview.chromium.org/312683004/diff/20001/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java#newcode78 components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java:78: ...

6 years, 6 months ago (2014-06-04 12:19:14 UTC) #7

johnme

6 years, 6 months ago (2014-06-04 13:50:43 UTC) #9

Message was sent while issue was closed.

On 2014/06/04 12:19:14, Michael van Ouwerkerk wrote:
> Just some nits.
> 
>
https://codereview.chromium.org/312683004/diff/20001/components/gcm_driver/an...
> File
>
components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java
> (right):
> 
>
https://codereview.chromium.org/312683004/diff/20001/components/gcm_driver/an...
>
components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java:23:
> private Context mContext;
> final?
> 
>
https://codereview.chromium.org/312683004/diff/20001/components/gcm_driver/an...
>
components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java:78:
> if (key == "from" || key == "collapse_key")
> That's the second time you're using these strings. Consider making them
> constants.

Thanks Michael, addressed these with https://codereview.chromium.org/317713002

Expand Messages | Collapse Messages