Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317713002: Address GCMDriver.java nits from crrev.com/312683004 (Closed)

Created:
6 years, 6 months ago by johnme
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Address GCMDriver.java nits from crrev.com/312683004 BUG=350378 TBR=fgorski@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael van Ouwerkerk
lgtm thanks :-)
6 years, 6 months ago (2014-06-04 13:49:30 UTC) #1
johnme
The CQ bit was checked by johnme@chromium.org
6 years, 6 months ago (2014-06-04 13:49:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/317713002/1
6 years, 6 months ago (2014-06-04 13:51:28 UTC) #3
fgorski
lgtm
6 years, 6 months ago (2014-06-04 14:49:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 18:40:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 21:57:09 UTC) #6
Message was sent while issue was closed. 
Change committed as 274921

Powered by Google App Engine
This is Rietveld 408576698