Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: components/gcm_driver/gcm_driver_android.h

Issue 312683004: JNI bindings for GCMDriverAndroid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renamed OnMessagesDeletedByServer Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_android.h
diff --git a/components/gcm_driver/gcm_driver_android.h b/components/gcm_driver/gcm_driver_android.h
index 0d0e8768016a4add003d77e2aed8a034eba8d76d..c7681072d542ebcb900a392791345f667f03460e 100644
--- a/components/gcm_driver/gcm_driver_android.h
+++ b/components/gcm_driver/gcm_driver_android.h
@@ -7,13 +7,14 @@
#include <jni.h>
+#include "base/android/scoped_java_ref.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "components/gcm_driver/gcm_driver.h"
namespace gcm {
-// GCMDriver implementation for Android.
+// GCMDriver implementation for Android, using Android GCM APIs.
class GCMDriverAndroid : public GCMDriver {
public:
GCMDriverAndroid();
@@ -40,10 +41,32 @@ class GCMDriverAndroid : public GCMDriver {
bool recording) OVERRIDE;
virtual std::string SignedInUserName() const OVERRIDE;
+ // Methods called from Java via JNI:
+ void OnRegisterFinished(JNIEnv* env,
+ jobject obj,
+ jstring app_id,
+ jstring registration_id,
+ jboolean success);
+ void OnUnregisterFinished(JNIEnv* env,
+ jobject obj,
+ jstring app_id,
+ jboolean success);
+ void OnMessageReceived(JNIEnv* env,
+ jobject obj,
+ jstring app_id,
+ jstring sender_id,
+ jstring collapse_key,
+ jobjectArray data_keys_and_values);
+ void OnMessagesDeleted(JNIEnv* env,
+ jobject obj,
+ jstring app_id);
+
// Register JNI methods.
static bool RegisterBindings(JNIEnv* env);
private:
+ base::android::ScopedJavaGlobalRef<jobject> java_ref_;
+
DISALLOW_COPY_AND_ASSIGN(GCMDriverAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698