Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 312553004: Revert 274310 "Introduce IPC::ChannelProxy::Create*() and IPC::S..." (Closed)

Created:
6 years, 6 months ago by Lambros
Modified:
6 years, 6 months ago
Reviewers:
Hajime Morrita
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 274310 "Introduce IPC::ChannelProxy::Create*() and IPC::S..." Broke Windows compile: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=180 FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\remoting\host\win\remoting_core.wts_session_process_delegate.obj.rsp /c ..\..\remoting\host\win\wts_session_process_delegate.cc /Foobj\remoting\host\win\remoting_core.wts_session_process_delegate.obj /Fdobj\remoting\remoting_core.cc.pdb c:\b\build\slave\win_x64_builder\build\src\remoting\host\win\wts_session_process_delegate.cc(386) : error C2661: 'IPC::ChannelProxy::ChannelProxy' : no overloaded function takes 4 arguments ninja: build stopped: subcommand failed. > Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() > > This change hides constructors of these classes so that we can turn > them polymorphic classes. > > Note that having almost identical ChannelProxy::Init*() isn't great > and they will be replaced by a factory-like abstraction in coming > changes. > > TEST=none > R=darin,cpu > BUG=377980 > > Review URL: https://codereview.chromium.org/301973003 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -359 lines) Patch
M trunk/src/apps/app_shim/app_shim_host_mac.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/apps/app_shim/chrome_main_app_mode_mac.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/service_process/service_process_control.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/service_process/service_process_control.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/service/service_ipc_server.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/nacl/browser/nacl_process_host.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/components/nacl/loader/nacl_listener.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/components/nacl/loader/nacl_trusted_listener.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/nacl/renderer/manifest_service_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/components/nacl/renderer/trusted_plugin_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M trunk/src/content/child/child_thread.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M trunk/src/content/child/npapi/np_channel_base.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/common/gpu/client/gpu_channel_host.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M trunk/src/content/common/gpu/gpu_channel.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/ipc/ipc_channel_proxy.h View 3 chunks +6 lines, -40 lines 0 comments Download
M trunk/src/ipc/ipc_channel_proxy.cc View 3 chunks +10 lines, -80 lines 0 comments Download
M trunk/src/ipc/ipc_sync_channel.h View 2 chunks +9 lines, -36 lines 0 comments Download
M trunk/src/ipc/ipc_sync_channel.cc View 1 chunk +9 lines, -55 lines 0 comments Download
M trunk/src/ipc/ipc_sync_channel_unittest.cc View 6 chunks +33 lines, -32 lines 0 comments Download
M trunk/src/ipc/ipc_test_base.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/ppapi/nacl_irt/manifest_service.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M trunk/src/ppapi/nacl_irt/ppapi_dispatcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/ppapi/proxy/proxy_channel.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M trunk/src/remoting/host/desktop_process.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/remoting/host/desktop_process_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/remoting/host/desktop_session_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/remoting/host/ipc_desktop_environment_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/remoting/host/ipc_util_posix.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/remoting/host/ipc_util_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/remoting/host/remoting_me2me_host.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M trunk/src/remoting/host/win/worker_process_launcher_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/tools/ipc_fuzzer/replay/replay_process.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M trunk/src/win8/metro_driver/chrome_app_view_ash.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/win8/viewer/metro_viewer_process_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lambros
6 years, 6 months ago (2014-06-02 20:27:48 UTC) #1
Lambros
Committed patchset #1 manually as r274315 (tree was closed).
6 years, 6 months ago (2014-06-02 20:29:39 UTC) #2
gmorrita
6 years, 6 months ago (2014-06-02 20:31:05 UTC) #3
Message was sent while issue was closed.
On 2014/06/02 20:29:39, Lambros wrote:
> Committed patchset #1 manually as r274315 (tree was closed).

Thanks for taking care of it.

Powered by Google App Engine
This is Rietveld 408576698