trunk/src/chrome/browser/service_process/service_process_control.cc - Issue 312553004: Revert 274310 "Introduce IPC::ChannelProxy::Create*() and IPC::S..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/service_process/service_process_control.cc

Issue 312553004: Revert 274310 "Introduce IPC::ChannelProxy::Create*() and IPC::S..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/browser/service_process/service_process_control.cc

===================================================================

--- trunk/src/chrome/browser/service_process/service_process_control.cc (revision 274314)

+++ trunk/src/chrome/browser/service_process/service_process_control.cc (working copy)

@@ -51,14 +51,15 @@

// TODO(hclam): Handle error connecting to channel.

const IPC::ChannelHandle channel_id = GetServiceProcessChannel();

- SetChannel(IPC::ChannelProxy::CreateNamedClient(

+ SetChannel(new IPC::ChannelProxy(

channel_id,

+ IPC::Channel::MODE_NAMED_CLIENT,

this,

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO).get()));

}

-void ServiceProcessControl::SetChannel(scoped_ptr<IPC::ChannelProxy> channel) {

- channel_ = channel.Pass();

+void ServiceProcessControl::SetChannel(IPC::ChannelProxy* channel) {

+ channel_.reset(channel);

}

void ServiceProcessControl::RunConnectDoneTasks() {