Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301973003: Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() (Closed)

Created:
6 years, 6 months ago by Hajime Morrita
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, creis+watch_chromium.org, kalyank, chromoting-reviews_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() This change hides constructors of these classes so that we can turn them polymorphic classes. Note that having almost identical ChannelProxy::Init*() isn't great and they will be replaced by a factory-like abstraction in coming changes. TEST=none R=darin,cpu BUG=377980 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274310

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Relanding correct patch #

Patch Set 5 : #

Patch Set 6 : Fixing mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -208 lines) Patch
M apps/app_shim/app_shim_host_mac.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M apps/app_shim/chrome_main_app_mode_mac.mm View 1 3 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/service_process/service_process_control.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/nacl/loader/nacl_trusted_listener.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/nacl/renderer/manifest_service_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/renderer/trusted_plugin_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +5 lines, -6 lines 0 comments Download
M content/child/child_thread.cc View 1 2 3 4 5 1 chunk +6 lines, -7 lines 0 comments Download
M content/child/npapi/np_channel_base.cc View 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 3 3 chunks +40 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 3 3 chunks +80 lines, -10 lines 0 comments Download
M ipc/ipc_sync_channel.h View 2 chunks +36 lines, -9 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 3 1 chunk +55 lines, -9 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 3 6 chunks +32 lines, -33 lines 0 comments Download
M ipc/ipc_test_base.cc View 3 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/nacl_irt/manifest_service.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.cc View 3 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/proxy_channel.cc View 3 1 chunk +8 lines, -5 lines 0 comments Download
M remoting/host/desktop_process.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/host/ipc_util_posix.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/ipc_util_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 1 2 3 4 2 chunks +4 lines, -6 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 3 1 chunk +5 lines, -5 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Hajime Morrita
6 years, 6 months ago (2014-05-29 21:02:01 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/301973003/diff/1/ipc/ipc_sync_channel.cc File ipc/ipc_sync_channel.cc (right): https://codereview.chromium.org/301973003/diff/1/ipc/ipc_sync_channel.cc#newcode419 ipc/ipc_sync_channel.cc:419: nit: only one new line
6 years, 6 months ago (2014-05-29 21:38:08 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-05-30 16:04:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/301973003/20001
6 years, 6 months ago (2014-05-30 16:05:26 UTC) #4
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-05-30 17:46:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/301973003/60001
6 years, 6 months ago (2014-05-30 17:48:53 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-05-30 20:56:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/301973003/80001
6 years, 6 months ago (2014-05-30 20:59:34 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 02:51:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 06:28:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/34390)
6 years, 6 months ago (2014-05-31 06:28:35 UTC) #11
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-06-02 17:06:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/301973003/80001
6 years, 6 months ago (2014-06-02 17:07:04 UTC) #13
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-06-02 17:17:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/301973003/100001
6 years, 6 months ago (2014-06-02 17:17:32 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 19:41:21 UTC) #16
Message was sent while issue was closed. 
Change committed as 274310

Powered by Google App Engine
This is Rietveld 408576698