Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs.

Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs. (Closed)

Created:
6 years, 6 months ago by Shu Chen

Modified:
6 years, 6 months ago

Reviewers:
Nikita (slow), Seigo Nonaka

CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Migrates Japanese IME IDs and stop migrating Chinese IME IDs. BUG=379432 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274299

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : rebased. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -68 lines)			Patch
M	chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	1 2 3 4	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	1 2 3	5 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.h	View	1 2 3 4	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1 2 3 4	5 chunks	+18 lines, -32 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_manager.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_manager.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/ui/login_display_host_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/preferences.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chromeos/ime/input_method_manager.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

lgtm but please don't make input method down-time even for Canary channel.

6 years, 6 months ago (2014-06-02 03:34:16 UTC) #2

Nikita (slow)

lgtm https://codereview.chromium.org/312453002/diff/60001/chrome/browser/chromeos/login/ui/login_display_host_impl.cc File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right): https://codereview.chromium.org/312453002/diff/60001/chrome/browser/chromeos/login/ui/login_display_host_impl.cc#newcode136 chrome/browser/chromeos/login/ui/login_display_host_impl.cc:136: void DetermineAndSaveHardwareKeyboard(const std::string& locale, nit: How about moving ...

6 years, 6 months ago (2014-06-02 06:24:20 UTC) #3

Shu Chen

https://codereview.chromium.org/312453002/diff/60001/chrome/browser/chromeos/login/ui/login_display_host_impl.cc File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right): https://codereview.chromium.org/312453002/diff/60001/chrome/browser/chromeos/login/ui/login_display_host_impl.cc#newcode136 chrome/browser/chromeos/login/ui/login_display_host_impl.cc:136: void DetermineAndSaveHardwareKeyboard(const std::string& locale, On 2014/06/02 06:24:20, Nikita Kostylev ...

6 years, 6 months ago (2014-06-02 09:49:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/312453002/80001

6 years, 6 months ago (2014-06-02 13:58:56 UTC) #6

Message was sent while issue was closed.

Change committed as 274299

Expand Messages | Collapse Messages