Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.h

Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_util.h
diff --git a/chrome/browser/chromeos/input_method/input_method_util.h b/chrome/browser/chromeos/input_method/input_method_util.h
index 5503e0a041a0207bd4c1216c60fe50ece3083015..49157d4a84856225109ddb09a24ff1b4f061b696 100644
--- a/chrome/browser/chromeos/input_method/input_method_util.h
+++ b/chrome/browser/chromeos/input_method/input_method_util.h
@@ -104,10 +104,9 @@ class InputMethodUtil {
// Migrates the legacy xkb id to extension based xkb id.
// Returns true if the given input method id list is modified,
// returns false otherwise.
- // TODO(shuchen): Remove this function after few milestones are passed.
- // See: http://crbug.com/345604
- bool MigrateXkbInputMethods(
- std::vector<std::string>* input_method_ids);
+ // This method should not be removed because it's required to transfer XKB
+ // input method ID from VPD into extension-based XKB input method ID.
+ bool MigrateInputMethods(std::vector<std::string>* input_method_ids);
// Updates the internal cache of hardware layouts.
void UpdateHardwareLayoutCache();

Powered by Google App Engine
This is Rietveld 408576698