chromeos/ime/input_method_manager.h - Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/ime/input_method_manager.h

Issue 312453002: Migrates Japanese IME IDs and stop migrating Chinese IME IDs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/ime/input_method_manager.h

diff --git a/chromeos/ime/input_method_manager.h b/chromeos/ime/input_method_manager.h

index 586606d5f9a16f185936cd235c1c5acc770ed6e6..09ae5c5747b9e71c5296e62dcff34ac4a4afb52a 100644

--- a/chromeos/ime/input_method_manager.h

+++ b/chromeos/ime/input_method_manager.h

@@ -185,10 +185,8 @@ class CHROMEOS_EXPORT InputMethodManager {

// If keyboard layout can be uset at login screen

virtual bool IsLoginKeyboard(const std::string& layout) const = 0;

- // Migrates the xkb id to extension-xkb id.

- // TODO(shuchen): Remove this function after few milestones are passed.

- // See: http://crbug.com/345604

- virtual bool MigrateXkbInputMethods(

+ // Migrates the input method id to extension-based input method id.

+ virtual bool MigrateInputMethods(

std::vector<std::string>* input_method_ids) = 0;

};

« no previous file with comments | « chrome/browser/chromeos/preferences.cc ('k') | no next file » | no next file with comments »