Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: public/web/WebSocket.h

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebSocket.h
diff --git a/public/web/WebSocket.h b/public/web/WebSocket.h
index 589a5098000ca9954900c3b8a67b9e12d640003e..01755bfb8ae3222cf22a9becbc98ec1460b6154a 100644
--- a/public/web/WebSocket.h
+++ b/public/web/WebSocket.h
@@ -33,6 +33,7 @@
#include "../platform/WebCommon.h"
#include "../platform/WebPrivatePtr.h"
+#include "../platform/WebString.h"
namespace WebCore { class WebSocketChannel; }
@@ -40,7 +41,6 @@ namespace blink {
class WebArrayBuffer;
class WebDocument;
-class WebString;
class WebURL;
class WebSocketClient;
@@ -84,11 +84,11 @@ public:
virtual bool setBinaryType(BinaryType) = 0;
virtual void connect(const WebURL&, const WebString& protocol) = 0;
- virtual WebString subprotocol() = 0;
- virtual WebString extensions() = 0;
+ virtual WebString subprotocol() { return WebString(); }
+ virtual WebString extensions() { return WebString(); }
virtual bool sendText(const WebString&) = 0;
virtual bool sendArrayBuffer(const WebArrayBuffer&) = 0;
- virtual unsigned long bufferedAmount() const = 0;
+ virtual unsigned long bufferedAmount() const { return 0; }
virtual void close(int code, const WebString& reason) = 0;
virtual void fail(const WebString& reason) = 0;
virtual void disconnect() = 0;

Powered by Google App Engine
This is Rietveld 408576698