Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: public/web/WebSocketClient.h

Issue 311993006: [WebSocket] bufferedAmount should not decrease inside a task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/WebSocketImpl.cpp ('K') | « public/web/WebSocket.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebSocketClient.h
diff --git a/public/web/WebSocketClient.h b/public/web/WebSocketClient.h
index 35896f82b0b9dfa8d66d74a9abdee8b24e19bf52..666a018cd370e48f8aed0e9dd8b44b7a28b32af4 100644
--- a/public/web/WebSocketClient.h
+++ b/public/web/WebSocketClient.h
@@ -46,13 +46,18 @@ public:
};
virtual ~WebSocketClient() { }
- virtual void didConnect() { }
+ virtual void didConnect(const WebString& subprotocol, const WebString& extensions) { }
virtual void didReceiveMessage(const WebString& message) { }
virtual void didReceiveArrayBuffer(const WebArrayBuffer& arrayBuffer) { }
virtual void didReceiveMessageError() { }
- virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) { }
+ virtual void didConsumeBufferedAmount(unsigned long consumed) { }
virtual void didStartClosingHandshake() { }
- virtual void didClose(unsigned long bufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const WebString& reason) { }
+ virtual void didClose(ClosingHandshakeCompletionStatus, unsigned short code, const WebString& reason) { }
+
+ // FIXME: Deperecate these methods.
+ virtual void didConnect() { }
+ virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) { }
+ virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const WebString& reason) { }
};
} // namespace blink
« Source/web/WebSocketImpl.cpp ('K') | « public/web/WebSocket.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698