Source/core/svg/properties/SVGPropertyTearOff.h - Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/properties/SVGPropertyTearOff.h

Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Review feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/QualifiedName.h ('K') | « Source/core/svg/properties/SVGListPropertyTearOffHelper.h ('k') | Source/core/svg/properties/SVGPropertyTearOff.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/properties/SVGPropertyTearOff.h

diff --git a/Source/core/svg/properties/SVGPropertyTearOff.h b/Source/core/svg/properties/SVGPropertyTearOff.h

index caee1657c7733250c7f932545dd139fb8132ce2c..e949dd01f819e564189ace7bce09402a6839f831 100644

--- a/Source/core/svg/properties/SVGPropertyTearOff.h

+++ b/Source/core/svg/properties/SVGPropertyTearOff.h

@@ -86,7 +86,7 @@ public:

virtual AnimatedPropertyType type() const = 0;

protected:

- SVGPropertyTearOffBase(SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = nullQName())

+ SVGPropertyTearOffBase(SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = QualifiedName::null())

: m_contextElement(contextElement)

, m_propertyIsAnimVal(propertyIsAnimVal)

, m_isReadOnlyProperty(false)

@@ -122,7 +122,7 @@ public:

}

protected:

- SVGPropertyTearOff(PassRefPtr<Property> target, SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = nullQName())

+ SVGPropertyTearOff(PassRefPtr<Property> target, SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = QualifiedName::null())

: SVGPropertyTearOffBase(contextElement, propertyIsAnimVal, attributeName)

, m_target(target)

{