Source/core/svg/properties/SVGPropertyTearOff.cpp - Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/properties/SVGPropertyTearOff.cpp

Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Review feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/properties/SVGPropertyTearOff.cpp

diff --git a/Source/core/svg/properties/SVGPropertyTearOff.cpp b/Source/core/svg/properties/SVGPropertyTearOff.cpp

index d7b97931d6b2e2f9e8b4b014bb9cbbbb827577c4..fd8189d55ddfd93486e68a43806cdc30f7afd42a 100644

--- a/Source/core/svg/properties/SVGPropertyTearOff.cpp

+++ b/Source/core/svg/properties/SVGPropertyTearOff.cpp

@@ -40,7 +40,7 @@ void SVGPropertyTearOffBase::commitChange()

ASSERT(!isImmutable());

if (!contextElement() || isAnimVal())

return;

- ASSERT(m_attributeName != nullQName());

+ ASSERT(m_attributeName != QualifiedName::null());

contextElement()->invalidateSVGAttributes();

contextElement()->svgAttributeChanged(m_attributeName);

}