Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Side by Side Diff: Source/core/svg/properties/SVGPropertyTearOff.h

Issue 311803003: [oilpan]: Avoid refcounting QualifiedName's nullQName when tracing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 } 79 }
80 80
81 const QualifiedName& attributeName() 81 const QualifiedName& attributeName()
82 { 82 {
83 return m_attributeName; 83 return m_attributeName;
84 } 84 }
85 85
86 virtual AnimatedPropertyType type() const = 0; 86 virtual AnimatedPropertyType type() const = 0;
87 87
88 protected: 88 protected:
89 SVGPropertyTearOffBase(SVGElement* contextElement, PropertyIsAnimValType pro pertyIsAnimVal, const QualifiedName& attributeName = nullQName()) 89 SVGPropertyTearOffBase(SVGElement* contextElement, PropertyIsAnimValType pro pertyIsAnimVal, const QualifiedName& attributeName = QualifiedName::null())
90 : m_contextElement(contextElement) 90 : m_contextElement(contextElement)
91 , m_propertyIsAnimVal(propertyIsAnimVal) 91 , m_propertyIsAnimVal(propertyIsAnimVal)
92 , m_isReadOnlyProperty(false) 92 , m_isReadOnlyProperty(false)
93 , m_attributeName(attributeName) 93 , m_attributeName(attributeName)
94 { 94 {
95 } 95 }
96 96
97 private: 97 private:
98 // These references are kept alive from V8 wrapper to prevent reference cycl es 98 // These references are kept alive from V8 wrapper to prevent reference cycl es
99 SVGElement* m_contextElement; 99 SVGElement* m_contextElement;
(...skipping 15 matching lines...) Expand all
115 { 115 {
116 m_target = target; 116 m_target = target;
117 } 117 }
118 118
119 virtual AnimatedPropertyType type() const OVERRIDE 119 virtual AnimatedPropertyType type() const OVERRIDE
120 { 120 {
121 return Property::classType(); 121 return Property::classType();
122 } 122 }
123 123
124 protected: 124 protected:
125 SVGPropertyTearOff(PassRefPtr<Property> target, SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = nu llQName()) 125 SVGPropertyTearOff(PassRefPtr<Property> target, SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = Qu alifiedName::null())
126 : SVGPropertyTearOffBase(contextElement, propertyIsAnimVal, attributeNam e) 126 : SVGPropertyTearOffBase(contextElement, propertyIsAnimVal, attributeNam e)
127 , m_target(target) 127 , m_target(target)
128 { 128 {
129 ASSERT(m_target); 129 ASSERT(m_target);
130 } 130 }
131 131
132 private: 132 private:
133 RefPtr<Property> m_target; 133 RefPtr<Property> m_target;
134 }; 134 };
135 135
136 } 136 }
137 137
138 #endif // SVGPropertyTearOff_h 138 #endif // SVGPropertyTearOff_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698