Add a win_force_console=1 GYP flag that makes chrome.exe and nacl64.exe console applications

Add a win_force_console=1 GYP flag that makes chrome.exe and nacl64.exe console applications

By default, /SUBSYSTEM:WINDOWS doesn't enable stdout/stderr that makes it harder to use logging and debug.
This flags allows developer to avoid that behaviour locally.

BUG=358267

[Timur Iskhodzhanov, 2014-06-05 17:43:01]

Scott,

Addressing your offline suggestion about http://crrev.com/275067 -- with this
patch any developer can make chrome.exe/nacl64.exe console apps.

I haven't changed the remaining targets (installers, basically) -- do you think
we should change them too or leave as is?

--
Tim

[scottmg, 2014-06-05 18:17:43]

Thanks. It'd be nice to have printf work in regular developer builds.

Theoretically, that's buildtype=Dev, which is the default, rather than
buildtype=Official, so we could put the main()s in #if !OFFICIAL_BUILD ||
FORCE_CONSOLE_SUBSYSTEM. But it also might annoy some people to have a console
pop up if they don't run from the command line. What do both of you think?

I don't think it's necessary to change other binaries.

https://codereview.chromium.org/311413003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/311413003/diff/1/build/common.gypi#newcode1223
build/common.gypi:1223: 'win_force_console%': '0',
could you make this win_force_console_subsystem to match the define please?

[Timur Iskhodzhanov, 2014-06-05 18:29:51]

I don't have a strong opinion on the dev vs Official logic, but popping up
a console with log might be useful for dinner devs.

Sure, I'll rename when I get back to work tomorrow.  Please tell me if I
can commit-with-a-rename if you and Carlos decide we don't want the console
to pop up.

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Timur Iskhodzhanov, 2014-06-05 18:29:51]

I don't have a strong opinion on the dev vs Official logic, but popping up
a console with log might be useful for dinner devs.

Sure, I'll rename when I get back to work tomorrow.  Please tell me if I
can commit-with-a-rename if you and Carlos decide we don't want the console
to pop up.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-06-05 18:43:20]

On 2014/06/05 18:29:51, Timur Iskhodzhanov wrote:
> I don't have a strong opinion on the dev vs Official logic, but popping up
> a console with log might be useful for dinner devs.
> 
> Sure, I'll rename when I get back to work tomorrow.  Please tell me if I
> can commit-with-a-rename if you and Carlos decide we don't want the console
> to pop up.
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

My preference would be #if !OFFICIAL_BUILD ||
FORCE_CONSOLE_SUBSYSTEM ==> main()

lgtm to land with rename and that change, but I'm not an owner for the required
cc files, so you should probably add someone in chrome/nacl/OWNERS.

[Timur Iskhodzhanov, 2014-06-05 18:47:58]

Maybe the OR should be put into GYP instead?

Like
Condition buildtype!=Official force_blah: 1
?

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Timur Iskhodzhanov, 2014-06-05 18:47:58]

Maybe the OR should be put into GYP instead?

Like
Condition buildtype!=Official force_blah: 1
?

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[cpu_(ooo_6.6-7.5), 2014-06-05 19:40:38]

How about instead to have a flag that causes code to call AllocConsole ?

This is probably better than having chrome with different subsystems.

[scottmg, 2014-06-05 20:23:12]

On 2014/06/05 19:40:38, cpu wrote:
> How about instead to have a flag that causes code to call AllocConsole ?
> 
> This is probably better than having chrome with different subsystems.

Yeah, you're right that's probably better for developer builds.

At the moment we call RouteStdioToConsole when --enable-logging on Windows. The
automatic selection of whether the let it go to the current output stream, or
call AllocConsole broke on the update to VS2013. I tried to fix it at
http://crrev.com/260738 (which has details on the CRT change) but for some
reason that I wasn't able to figure out, that change causes nacl_integration
tests to hang on the bots (but not my local machine).

https://code.google.com/p/chromium/codesearch#chromium/src/base/process/launc...

So, it's kind of a hack, but how about dropping this change, and instead adding
an optional argument to the logging switch like --enable-logging=alloc-console
that will cause RouteStdioToConsole always call AllocConsole? (I can do that if
you want Timur, since it really has nothing to do with what you were working
on.)

[Timur Iskhodzhanov, 2014-06-06 11:19:33]

--enable-logging=force-console, maybe?

[cpu_(ooo_6.6-7.5), 2014-06-10 01:31:37]

sounds good to me.

[cpu_(ooo_6.6-7.5), 2014-06-10 01:32:11]

adding rvargas again for sanity check.

[rvargas (doing something else), 2014-06-10 02:04:40]

I'm getting a little confused by this.

If the desired is to enable printf debugging, why not use logs instead for that?
(seems like that's the conclusion of the thread)

If the desire is to deal with logs easier, what's wrong with sawbuck?
(http://www.chromium.org/for-testers/enable-logging)

Between forcing everyone dev to have a console and adding another command line
option to get one, I'd also go with the command line.

Between adding another command line option (+supported workflow +more log code)
and just sending people to sawbuck I'd go with sawbuck.

My last point is that, although there's lot of stuff on dev builds or through
command line options that are not intended for users (makes us run different
code etc), attaching a console (or changing the subsystem) is something that
raises internal alarms... it may be just FUD, but we probably should not do that
unless there's a strong reason for it.