Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4445)

Unified Diff: chrome/chrome_exe.gypi

Issue 311413003: Add a win_force_console=1 GYP flag that makes chrome.exe and nacl64.exe console applications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 30dccfde589eb031364cc64f2eed08e046c6bbf3..a9e9c675bf46ece28d748e6e4bc540431e50d729 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -518,9 +518,7 @@
],
'AdditionalDependencies': [ 'wintrust.lib' ],
'conditions': [
- ['asan==0', {
- # Set /SUBSYSTEM:WINDOWS for chrome.exe itself, except for the
- # AddressSanitizer build where console output is important.
+ ['win_force_console==0', {
'SubSystem': '2',
}],
],
@@ -648,7 +646,11 @@
'msvs_settings': {
'VCLinkerTool': {
'ImportLibrary': '$(OutDir)\\lib\\nacl64_exe.lib',
- 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
+ 'conditions': [
+ ['win_force_console==0', {
+ 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
+ }],
+ ],
},
},
'configurations': {
« build/common.gypi ('K') | « chrome/chrome_dll.gypi ('k') | chrome/nacl/nacl_exe_win_64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698