Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: build/common.gypi

Issue 311413003: Add a win_force_console=1 GYP flag that makes chrome.exe and nacl64.exe console applications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5a2753f08af3172e7c9d25e2efb04e6479d74aad..a8cf87364e03afe1926ede42f35f96a73ea14c6f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1217,6 +1217,11 @@
# remaining.
'win_third_party_warn_as_error%': 'true',
+ # Force /SUBSYSTEM:CONSOLE for some executables that use /SUBSYSTEM:WINDOWS
+ # by default. This should simplify debugging since windowed applications
+ # don't play well with stdout/stderr.
+ 'win_force_console%': '0',
scottmg 2014/06/05 18:17:42 could you make this win_force_console_subsystem to
+
# Clang stuff.
'clang%': '<(clang)',
'make_clang_dir%': 'third_party/llvm-build/Release+Asserts',
@@ -1828,6 +1833,9 @@
}],
['asan==1', {
'win_use_allocator_shim%': 0,
+ # The AddressSanitizer build should be a console program
+ # as it prints out stuff on stderr.
+ 'win_force_console%': '1',
}],
['component=="shared_library" and "<(GENERATOR)"=="ninja"', {
# Only enabled by default for ninja because it's buggy in VS.
@@ -2612,6 +2620,11 @@
'<(DEPTH)/third_party/wtl/include',
],
'conditions': [
+ ['win_force_console!=0', {
+ 'defines': [
+ "FORCE_CONSOLE_SUBSYSTEM",
+ ],
+ }],
['win_z7!=0', {
'msvs_settings': {
# Generates debug info when win_z7=1
« no previous file with comments | « no previous file | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698