Issue 310903003: Don’t throw on assignments to non-assignable expressions. Allow non-literal indices in assignable e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310903003: Don’t throw on assignments to non-assignable expressions. Allow non-literal indices in assignable e… (Closed)

Created:
6 years, 6 months ago by justinfagnani

Modified:
6 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don’t throw on assignments to non-assignable expressions. Allow non-literal indices in assignable expressions. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=36955

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -23 lines)			Patch
M	pkg/polymer_expressions/lib/eval.dart	View	2 chunks	+17 lines, -21 lines	0 comments	Download
M	pkg/polymer_expressions/lib/polymer_expressions.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer_expressions/test/eval_test.dart	View	3 chunks	+40 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

justinfagnani

6 years, 6 months ago (2014-06-03 22:31:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36955 (presubmit successful).